-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change style of bouquet to me more consistent with Lunaria and NFT Sender #51
Conversation
✅ Deploy Preview for absurd-use ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: KillariDev <[email protected]>
Transactions and import diff
Error handling clean, inputs for import better, new style
Going to make some more PR's to the style branch. Then thoroughly test again before merging into main.
|
Co-authored-by: KillariDev <[email protected]>
Add click to import button on warning card about transaction stack diff
Co-authored-by: KillariDev <[email protected]>
Configure Components
Co-authored-by: KillariDev <[email protected]>
Settings Modal inputs now in sync with state
Co-authored-by: KillariDev <[email protected]>
…nces Simulate submit clearer responces
|
This PR has a decent amount of changes, most have been reviewed already in small PR's into this branch, but I think some eyes on this before merging to main may be a good idea. |
@@ -17,7 +19,13 @@ type PendingBundle = { | |||
included: boolean | |||
} | |||
} | |||
error?: Error | |||
error?: Error, | |||
success?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess here you didn't want to change the type to be either error or success but not both or neither?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried change types earlier, but found that I would need to change a lot of how I checked the data too. So its new issue #64
Co-authored-by: KillariDev <[email protected]>
Issues and styling for each section will be addressed in separate PR's and then merged into main once all are complete.