Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style of bouquet to me more consistent with Lunaria and NFT Sender #51

Merged
merged 37 commits into from
Aug 20, 2023

Conversation

0xjimmy
Copy link
Contributor

@0xjimmy 0xjimmy commented Jul 18, 2023

  • Updated buttons
  • Added Footer
  • Changed Navbar Design

Issues and styling for each section will be addressed in separate PR's and then merged into main once all are complete.

image
image
image

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for absurd-use ready!

Name Link
🔨 Latest commit 974d611
🔍 Latest deploy log https://app.netlify.com/sites/absurd-use/deploys/64e29eb14e814700080d4f95
😎 Deploy Preview https://deploy-preview-51--absurd-use.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xjimmy
Copy link
Contributor Author

0xjimmy commented Jul 25, 2023

Going to make some more PR's to the style branch. Then thoroughly test again before merging into main.

  • Settings input values don't update to match current settings on open and reset click
  • Add back Configure section and fix error with caching wrong private key inputs
  • Implement refund from burner / new burner
  • Submit UX + show links to confirmed transactions on Etherscan on complete

@0xjimmy
Copy link
Contributor Author

0xjimmy commented Aug 15, 2023

Appears to be issue when connecting sometimes with just Metamask (Or rather no Interceptor) Fixed

@0xjimmy 0xjimmy requested review from epheph and MicahZoltu August 15, 2023 02:22
@0xjimmy
Copy link
Contributor Author

0xjimmy commented Aug 15, 2023

This PR has a decent amount of changes, most have been reviewed already in small PR's into this branch, but I think some eyes on this before merging to main may be a good idea.

@0xjimmy 0xjimmy requested a review from KillariDev August 15, 2023 06:37
app/ts/components/Settings.tsx Outdated Show resolved Hide resolved
@@ -17,7 +19,13 @@ type PendingBundle = {
included: boolean
}
}
error?: Error
error?: Error,
success?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess here you didn't want to change the type to be either error or success but not both or neither?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried change types earlier, but found that I would need to change a lot of how I checked the data too. So its new issue #64

@0xjimmy 0xjimmy merged commit ecf2fdb into main Aug 20, 2023
@0xjimmy 0xjimmy deleted the style branch October 5, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants